Fix syntax error in isValidEmail method - #8
Closed
devin-ai-integration[bot] wants to merge 4 commits into
Closed
devin-ai-integration[bot] wants to merge 4 commits into
devin-ai-integration[bot] wants to merge 4 commits into
Conversation
Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Update actions/checkout from v2 to v5 - Update actions/setup-java from v2 to v5 - Update actions/cache from v2 to v4 This fixes the CI failure caused by GitHub's shutdown of v2 actions. Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
- Update build.gradle to use googleJavaFormat('1.7') for Java 11 compatibility
- Remove trailing whitespace in Util.java
- Auto-format DefaultJwtServiceTest.java to comply with google-java-format rules
The default google-java-format version had module access errors with Java 11.
Version 1.7 resolves these compatibility issues.
Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix syntax error in isValidEmail method and update deprecated GitHub Actions
Summary
This PR addresses a CI build failure that had two root causes:
isValidEmailmethod inUtil.javaThe changes include:
isValidEmailmethodReview & Testing Checklist for Human
!= null && contains("@"). Confirm this basic validation meets your requirements, as it would accept strings like "@@", "a@", or "@b" as valid emailsisValidEmailmethod has no test coverage. Should we add tests to verify the validation behavior?Notes
isValidEmailmethod is not yet used anywhere in the codebaseLink to Devin run: https://app.devin.ai/sessions/981a350c109f4b4c83d56eec4eeb7802
Requested by: @samfert-codeium